andreas/heartbeat
Public Access
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases 44 Wiki Activity

fix: preserve .hb.yaml file permissions on backup and atomic write

Browse Source
This commit is contained in:
Andreas Wrede
2026-05-09 12:04:46 -04:00
parent 15f7e6a64d
commit 2800de0b4a
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hbd/server/configio.py
+5
View File
@@ -48,9 +48,12 @@ def write_config(path: str, data) -> None:
while os.path.exists(backup_path): while os.path.exists(backup_path):
n += 1 n += 1
backup_path = f"{path}.bak.{ts}-{n}" backup_path = f"{path}.bak.{ts}-{n}"
orig_mode = None
if os.path.exists(path): if os.path.exists(path):
orig_mode = os.stat(path).st_mode
with open(path, "rb") as src, open(backup_path, "wb") as dst: with open(path, "rb") as src, open(backup_path, "wb") as dst:
dst.write(src.read()) dst.write(src.read())
os.chmod(backup_path, orig_mode)
backups = sorted(glob.glob(f"{path}.bak.*"), reverse=True) backups = sorted(glob.glob(f"{path}.bak.*"), reverse=True)
for old in backups[10:]: for old in backups[10:]:
os.unlink(old) os.unlink(old)
@@ -58,6 +61,8 @@ def write_config(path: str, data) -> None:
try: try:
with open(tmp, "w", encoding="utf-8") as f: with open(tmp, "w", encoding="utf-8") as f:
_make_yaml().dump(data, f) _make_yaml().dump(data, f)
if orig_mode is not None:
os.chmod(tmp, orig_mode)
os.replace(tmp, path) os.replace(tmp, path)
except Exception: except Exception:
try: try: