link and flake cleanup

hbd/notify.py

@@ -1,4 +1,5 @@
 """Notification helpers: email, pushover, mattermost, signal and dispatcher."""
+
 import logging
 from typing import Optional
 import http.client
@@ -6,7 +7,6 @@ import urllib.parse
 import subprocess
 import smtplib
 import time
-import traceback
 
 DEFAULT_PUSHPROVIDERS = ["all", "pushover", "mattermost", "signal"]
 
@@ -24,7 +24,7 @@ def setup(cfg: dict):
 def send_email(toaddrs, smtpserver, sender, subject, body, debug=0):
     """Send a plain email via SMTP. Returns True on success."""
     try:
-        smtpport = _config.get("smtpport", 587) 
+        smtpport = _config.get("smtpport", 587)
         server = smtplib.SMTP(smtpserver, smtpport)
         if debug > 0:
             server.set_debuglevel(1)
@@ -57,10 +57,15 @@ def email(subject: str, msg: str, debug: int = 0) -> bool:
     and sender address.
     """
     toaddrs = _config.get("toemail")
-    fromemail = _config.get("fromemail") 
-    smtpserver = _config.get("smtpserver") 
+    fromemail = _config.get("fromemail")
+    smtpserver = _config.get("smtpserver")
     if not toaddrs or not fromemail or not smtpserver:
-        logger.warning("email config incomplete: toemail=%s, fromemail=%s, smtpserver=%s", toaddrs, fromemail, smtpserver)
+        logger.warning(
+            "email config incomplete: toemail=%s, fromemail=%s, smtpserver=%s",
+            toaddrs,
+            fromemail,
+            smtpserver,
+        )
         return False
     date = time.strftime("%a, %d %b %Y %H:%M:%S %z", time.localtime())
     body = "To: %s\nFrom: %s\nSubject: %s\nDate: %s\n\n%s" % (
@@ -91,7 +96,15 @@ def pushover(token: str, user: str, msg: str, debug: int = 0) -> bool:
         return False
 
 
-def pushmattermost(host: str, token: str, channel: str, msg: str, username: str = "hbd", icon: Optional[str] = None, debug: int = 0) -> bool:
+def pushmattermost(
+    host: str,
+    token: str,
+    channel: str,
+    msg: str,
+    username: str = "hbd",
+    icon: Optional[str] = None,
+    debug: int = 0,
+) -> bool:
     """Send a message to Mattermost via simple webhook driver if available.
 
     This helper tries to import mattermostdriver.Driver and uses webhooks if present.
@@ -115,7 +128,9 @@ def pushmattermost(host: str, token: str, channel: str, msg: str, username: str
         return False
 
 
-def pushsignal(signal_cli_bin: str, user: str, recipient: str, msg: str, debug: int = 0) -> bool:
+def pushsignal(
+    signal_cli_bin: str, user: str, recipient: str, msg: str, debug: int = 0
+) -> bool:
     """Send a message via signal-cli (requires local installation).
 
     Uses subprocess to call signal-cli. Returns True if the command succeeded.
@@ -125,7 +140,7 @@ def pushsignal(signal_cli_bin: str, user: str, recipient: str, msg: str, debug:
     try:
         res = subprocess.run(CLI, capture_output=True)
         if res.returncode != 0:
-            logger.error("signal failed: %s". res.stderr.decode())
+            logger.error("signal failed: %s".res.stderr.decode())
             return False
         logger.debug("signal sent: %s", res.stdout.decode())
         return True
@@ -148,13 +163,32 @@ def pushmsg(cfg: dict, msg: str, debug: int = 0):
     results = {}
     p = cfg.get("pushsrv", "pushover")
     if p in ("all", "pushover"):
-        ok = pushover(cfg.get("pushover_token", ""), cfg.get("pushover_user", ""), msg, debug=debug)
+        ok = pushover(
+            cfg.get("pushover_token", ""),
+            cfg.get("pushover_user", ""),
+            msg,
+            debug=debug,
+        )
         results["pushover"] = ok
     if p in ("all", "mattermost"):
-        ok = pushmattermost(cfg.get("matter_host", ""), cfg.get("matter_token", ""), cfg.get("matter_channel", ""), msg, username=cfg.get("matter_username", "hbd"), icon=cfg.get("matter_icon"), debug=debug)
+        ok = pushmattermost(
+            cfg.get("matter_host", ""),
+            cfg.get("matter_token", ""),
+            cfg.get("matter_channel", ""),
+            msg,
+            username=cfg.get("matter_username", "hbd"),
+            icon=cfg.get("matter_icon"),
+            debug=debug,
+        )
         results["mattermost"] = ok
     if p in ("all", "signal"):
-        ok = pushsignal(cfg.get("signal_cli", "/usr/local/bin/signal-cli"), cfg.get("signal_user", ""), cfg.get("signal_recipient", ""), msg, debug=debug)
+        ok = pushsignal(
+            cfg.get("signal_cli", "/usr/local/bin/signal-cli"),
+            cfg.get("signal_user", ""),
+            cfg.get("signal_recipient", ""),
+            msg,
+            debug=debug,
+        )
         results["signal"] = ok
     if p in ("all", "email"):
         ok = email("Heartbeat notification", msg, debug=debug)
@@ -166,4 +200,3 @@ def pushmsg(cfg: dict, msg: str, debug: int = 0):
 def pushmsg_from_config(msg: str, debug: int = 0) -> dict:
     """Use the module-level configuration dict to dispatch a push message."""
     return pushmsg(_config, msg, debug=debug)
-