From a7bb1832224ed5ab1b803f0514aa4c2b9fb27d51 Mon Sep 17 00:00:00 2001 From: Andreas Wrede Date: Sat, 9 May 2026 08:31:09 -0400 Subject: [PATCH] test: assert warning logged when get_providers skips invalid entries --- tests/test_oauth.py | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/tests/test_oauth.py b/tests/test_oauth.py index 056e736..e8af425 100644 --- a/tests/test_oauth.py +++ b/tests/test_oauth.py @@ -423,24 +423,40 @@ def test_get_providers_nextcloud_urls_and_path(): assert p.scope == "" -def test_get_providers_skips_missing_client_id(): +def test_get_providers_skips_missing_client_id(caplog): cfg = {"oauth": {"gitea": {"url": "https://git.example.com", "client_secret": "cs"}}} - assert oauth.get_providers(cfg) == [] + import logging + with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"): + result = oauth.get_providers(cfg) + assert result == [] + assert caplog.text # a warning was logged -def test_get_providers_skips_missing_client_secret(): +def test_get_providers_skips_missing_client_secret(caplog): cfg = {"oauth": {"gitea": {"url": "https://git.example.com", "client_id": "cid"}}} - assert oauth.get_providers(cfg) == [] + import logging + with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"): + result = oauth.get_providers(cfg) + assert result == [] + assert caplog.text # a warning was logged -def test_get_providers_skips_missing_url_for_gitea(): +def test_get_providers_skips_missing_url_for_gitea(caplog): cfg = {"oauth": {"gitea": {"type": "gitea", "client_id": "cid", "client_secret": "cs"}}} - assert oauth.get_providers(cfg) == [] + import logging + with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"): + result = oauth.get_providers(cfg) + assert result == [] + assert caplog.text # a warning was logged -def test_get_providers_skips_missing_url_for_nextcloud(): +def test_get_providers_skips_missing_url_for_nextcloud(caplog): cfg = {"oauth": {"nc": {"type": "nextcloud", "client_id": "cid", "client_secret": "cs"}}} - assert oauth.get_providers(cfg) == [] + import logging + with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"): + result = oauth.get_providers(cfg) + assert result == [] + assert caplog.text # a warning was logged def test_get_providers_github_no_url_required():