From f24500a6b5fa48de3f7549715b517cb8a9430bc9 Mon Sep 17 00:00:00 2001
From: Andreas Wrede <andreas@wrede.ca>
Date: Sat, 9 May 2026 08:34:48 -0400
Subject: [PATCH] fix: copy field_map/profile_data_path in get_providers;
 improve caplog assertions

---
 hbd/server/oauth.py |  4 ++--
 tests/test_oauth.py | 13 +++++--------
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/hbd/server/oauth.py b/hbd/server/oauth.py
index fbe619b..60f7d2d 100644
--- a/hbd/server/oauth.py
+++ b/hbd/server/oauth.py
@@ -149,8 +149,8 @@ def get_providers(config: dict) -> list[ResolvedProvider]:
             scope=defn["scope"],
             client_id=client_id,
             client_secret=client_secret,
-            field_map=defn["field_map"],
-            profile_data_path=defn["profile_data_path"],
+            field_map=dict(defn["field_map"]),
+            profile_data_path=list(defn["profile_data_path"]),
         ))
     return result
 
diff --git a/tests/test_oauth.py b/tests/test_oauth.py
index e8af425..c9d0ee1 100644
--- a/tests/test_oauth.py
+++ b/tests/test_oauth.py
@@ -1,3 +1,4 @@
+import logging
 import time as time_mod
 from unittest.mock import AsyncMock, MagicMock, patch
 from urllib.parse import urlparse, parse_qs
@@ -425,38 +426,34 @@ def test_get_providers_nextcloud_urls_and_path():
 
 def test_get_providers_skips_missing_client_id(caplog):
     cfg = {"oauth": {"gitea": {"url": "https://git.example.com", "client_secret": "cs"}}}
-    import logging
     with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"):
         result = oauth.get_providers(cfg)
     assert result == []
-    assert caplog.text  # a warning was logged
+    assert "missing" in caplog.text.lower()
 
 
 def test_get_providers_skips_missing_client_secret(caplog):
     cfg = {"oauth": {"gitea": {"url": "https://git.example.com", "client_id": "cid"}}}
-    import logging
     with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"):
         result = oauth.get_providers(cfg)
     assert result == []
-    assert caplog.text  # a warning was logged
+    assert "missing" in caplog.text.lower()
 
 
 def test_get_providers_skips_missing_url_for_gitea(caplog):
     cfg = {"oauth": {"gitea": {"type": "gitea", "client_id": "cid", "client_secret": "cs"}}}
-    import logging
     with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"):
         result = oauth.get_providers(cfg)
     assert result == []
-    assert caplog.text  # a warning was logged
+    assert "url" in caplog.text.lower()
 
 
 def test_get_providers_skips_missing_url_for_nextcloud(caplog):
     cfg = {"oauth": {"nc": {"type": "nextcloud", "client_id": "cid", "client_secret": "cs"}}}
-    import logging
     with caplog.at_level(logging.WARNING, logger="hbd.server.oauth"):
         result = oauth.get_providers(cfg)
     assert result == []
-    assert caplog.text  # a warning was logged
+    assert "url" in caplog.text.lower()
 
 
 def test_get_providers_github_no_url_required():